Fix extra fields for Beats

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack

GNU General Public License v3.0

9 stars 8 forks source link

Fix extra fields for Beats #297

Closed widhalmt closed 5 months ago

widhalmt commented 5 months ago

fixes #296

widhalmt commented 5 months ago

I still have comments with a more sophisticated check. To be honest, today feels like I'm cursed. Couldn't type a single straight line. Since this fix is somewhat time critical I go with a manual check this time. If you're reviewing you're very welcome to think this approach is wrong and come up with a better solution. I for my part tried my best for today. Maybe I'll do something better later but by then the fix should be integrated for a long time already.

widhalmt commented 5 months ago

Helpful for review:

Added two fields to converge.yml of the beats_peculiar molecule scenario
In the output of the verify stage of the beats_peculiar scenario you should see the fields added to fielbeat.yml
Filebeat needs to run because there's a chance that it refuses to start or crashes when the configuration contains errors

widhalmt commented 5 months ago

Needs #300 to be fixed before all neccessary checks can run.

tbauriedel commented 5 months ago

@widhalmt Since #300 is implemented now, you will also have to merge these changes into your PR that the pipelines can start.

widhalmt commented 5 months ago

@tbauriedel thanks. Waiting for the merge queue to complete.

tbauriedel commented 5 months ago

@widhalmt I have updated the verification for the fields for beats_peculiar. I did some local tests. Ir works. If the field is not defined, it fails

Correct me if I am wrong. But currently no fields are defined inside the elasticstack_default converge? So no test necessary?

widhalmt commented 5 months ago

Exactly. I'm trying to keep elasticstack_default to defaults as much as possible. So we make sure you can use the collection with defaults without digging through every option.