search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Remove actions for pushs #303

Closed tbauriedel closed 5 months ago

tbauriedel commented 5 months ago

At the moment workflows are triggered for PRs and pushs.

The workflow to contribute says that a PR must be created beforehand for each contribution into main. For this reason (and to avoid duplicate workflows), github workflows should only be triggered for PRs.

I have also checked this branch before creating the PR. No workflow were scheduled.

Fixes #302

widhalmt commented 5 months ago

Looks good. I'll let pipelines run and check if everything works as expected. Maybe, when all succeeded we can do another push and try of they still work? The both of us are quite sure that it will work but this might still help with finding unexpected behaviour.

tbauriedel commented 5 months ago

I have also enabled that the linter will run always.

tbauriedel commented 5 months ago

Looks good. I'll let pipelines run and check if everything works as expected. Maybe, when all succeeded we can do another push and try of they still work? The both of us are quite sure that it will work but this might still help with finding unexpected behaviour.

Sure. You can start one after that. If something is missing, I can check that again.

widhalmt commented 5 months ago

When everything's done, I'll just update the branch from main. We should then see if they run again. If they do, I'll approve. This should speed up checks again (by a lot)

tbauriedel commented 5 months ago

Works ;)