search

NETWAYS / check_hp_firmware

Icinga / Nagios check plugin to verify HPE controllers an SSD disks are not affected by certain vulnerabilities
GNU General Public License v2.0
2 stars 1 forks source link

small refactors mostly to improve error handling and readability #20

Closed finfinack closed 4 years ago

finfinack commented 4 years ago

Proposing a few changes to make the code slightly more readable (e.g. by returning earlier and removing indentation in GetSummary) and handle errors in a more go way where this wasn't already the case anyway.

lazyfrosch commented 4 years ago

The changes make sense for code style, may I asked the intentions of your work, as it is no functional change?

finfinack commented 4 years ago

Thanks! And of course, that's a fair question. I was looking around for hacktober contributions in projects which are primarily security related (as I come from that field), are in Go (because I like that language) and won't require me to spend hours getting familiar with a new codebase.