search

NETWAYS / go-check

A Golang library to create monitoring plugins for Icinga
https://pkg.go.dev/github.com/NETWAYS/go-check
GNU General Public License v2.0
13 stars 4 forks source link

Remove http sub package to focus the purpose of this library #90

Closed RincewindsHat closed 1 year ago

martialblog commented 1 year ago

@RincewindsHat I know this i used in some downstream code.

I do think the code is useful, it just might need a different place.

martialblog commented 1 year ago

I will have a look at our code base to see where we use this. I think it is only a few tests, if so I will just copy this code where it's needed.

RincewindsHat commented 1 year ago

or put in another repo? Vendoring it to five places might more pain in the longterm.

martialblog commented 1 year ago

Yeah that could also be an option. I do think it is not even five places, let me check and then we will see.

martialblog commented 1 year ago

As far as I can see, it is only used in: check_cloud_azure, check_cloud_gcp, check_cloud_aws

I think, a we can take a little duplication over the wrong abstraction.