search

NETWAYS / support-collector

The support collector allows our customers to collect relevant information from their servers. A resulting ZIP file can then be provided to our support team for further inspection.
https://www.netways.de/en/technologies/icinga/support-subscription/
GNU General Public License v3.0
0 stars 0 forks source link

remove unused variables #99

Closed tbauriedel closed 1 year ago

tbauriedel commented 1 year ago

Remove unused variables in tests

martialblog commented 1 year ago

I will have a look at it this week. Not really sure what these test functions do.

tbauriedel commented 1 year ago

Most (to my knowledge even all) just call their Collect() function without using the t *testing.T variable.

For the future, it would be appropriate to expand the tests somewhat at this point (as far as possible and necessary).

tbauriedel commented 1 year ago

We should rather tackle the whole thing directly once cleanly instead of just using the variable somehow. I'll take care of the whole thing.

martialblog commented 1 year ago

I updated the PR.

The Test functions now have more to do and use the testing.T object.

Plus some updates to the CI.