search

NEU-ABLE-LAB / SurveyJs-HomeAssistant-Card

0 stars 0 forks source link

Why have we referenced a git key here? #5

Open Maharshi-Pathak opened 3 months ago

Maharshi-Pathak commented 3 months ago

https://github.com/NEU-ABLE-LAB/SurveyJs-HomeAssistant-Card/blame/79da49c9958354dd76c001a93ee65a48cb9d00e6/package.json#L11

Maharshi-Pathak commented 3 months ago

Why not just "https://github.com/NEU-ABLE-LAB/SurveyJs-HomeAssistant-Card"? like this other card https://github.com/piitaya/lovelace-mushroom/blob/76d96c748afc8fbcf5d60673d286016a253dc1c1/package.json#L17C19-L18C12

manikanta-reddy-thikkavarapu-neu commented 2 months ago

The repository URL in the package.json includes a personal access token (PAT) as part of the URL: "url": "git+https://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@github.com/NEU-ABLE-LAB/SurveyJs-HomeAssistant-Card.git". This token is used for authentication, granting the user specific access rights to the repository.

Since we are using a public repository, it's better to remove PAT from the URL.

I've created a pat-remove branch, where I've removed the PAT from the URL.