"Add to a Set." modal displays more Sets than user has access to

[sarahjeansweeney]

I was working with a user this morning to go over how to add collections to a Set. While walking him through the process, I noticed the "Add to a Set" modal lists 110 Sets for him to choose from.

His user only has 20 Sets in his list of personal and collaborative Sets:

I'm nots sure what the other 90 Sets are. There are 301 Sets total, so it can't be all Sets. My best guess is that it's his Sets plus all public Sets.

Either way, this modal should display only the Sets that he has edit access to.

[sarahjeansweeney]

It seems now the modal displays fewer Sets than it should. I can edit 135 collaborative and personal Sets:

When I click "Save for Later", only 123 Sets show up in the Add to Sets modal:

I know that the "Associated Files" Set is missing from the modal - I haven't looked to see what the other missing Sets are.

[dgcliff]

Taking a look

[sarahjeansweeney]

Adding a file to a Set now brings up a modal with very few Sets. Of my 135 Sets, only 3 show up when I click "Add to Set":

The other user from the first message in this ticket sees 0 Sets:

[sarahjeansweeney]

FWIW, I think the three Sets that I see were all created around the same time.

[dgcliff]

This has been fixed, but the numbers will not match collaborative + deposited/owned sets.

As per #1090 "Collaborative" is the list of items which are readable and/or editable as per the users grouper groups. This list includes sets to which a user will not be able to add items.

Therefore, the solr logic for this modal is going to be:

Owned/deposited by the user + editable according to the users grouper groups

[sarahjeansweeney]

This makes sense - the modal lists a more accurate number of sets now.