NEUBIAS / bise

BIII development repository
http://biii.eu
GNU General Public License v2.0
5 stars 14 forks source link

Workflow steps are displayed even if not workflow #189

Closed PerrineGilloteaux closed 1 year ago

PerrineGilloteaux commented 1 year ago

Workflow steps are displayed even if not workflow (with the default step image processing), but there are not accessible, and quick edit remove will not remove them. Expected behavior: if not a wf, wf step not displayed.

czhci commented 1 year ago

not only show as "image processing", can also be "operation", as in https://biii.eu/vast-lite.

miura commented 1 year ago

Maybe this is fixed with Drupal9.5?

http://test.biii.eu/

pls check.

PerrineGilloteaux commented 1 year ago

Drupal 9 does not fixed it, I've just tested from test.biii.eu. It comes from the configuration of the view, working on it (will point you here the associated commit)

PerrineGilloteaux commented 1 year ago

fixed and tested. 395b8263050c800fe452df93b7db8dea892b82a4 NB: one the fix is deployed, the correction will not apply retroactively: I am testing actions to trigger an edit for all Software entry on my local version. If not working, all entries will have to be parse to edit with no revisions, just to trigger the change. Will let you know.

PerrineGilloteaux commented 1 year ago

Ok, so after the fix a simple edit save will reset the display (for now if you want to remove wf step you have to set the sf step to wf, erase the field, then set back the wf type to what it was (component or collection). I've tested some bulk operations with the hope they will have the same effect but no. So my suggestion is 1) deploy the fix above (that make in any case the correction easier, and prevent it to happen again) 2) from the content view, click edit then save all sf entries with a pb.