Open tischi opened 2 years ago
Thanks a lot for your comments @tischi!
I updated it as follows.
Concept map: updated. I think the 'official' terms for the different pixels are slab pixels, junction pixels, and endpoint pixels (that's also what is tagged in the 'analyze skeleton' result (https://imagej.net/plugins/analyze-skeleton/?amp=1), so I am using those terms now.
Figure:
Activity: fixed indentation and used the tickbox notation. Thanks! Exercises: changed to capitals and put the questions in the exercise preface and removed the solution syntax.
@tischi , sorry for bothering you... actually I am now having trouble pushing the changes.. Before I mess up badly, could you please advice me on this:
To https://github.com/NEUBIAS/training-resources.git ! [rejected] skeletonization -> skeletonization (non-fast-forward) error: failed to push some refs to 'https://xxxx@github.com/NEUBIAS/training-resources.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
I did run the following prior to making changes: git checkout master git pull git checkout skeletonization git merge master
It says it is up to date with master but I guess it is not up to date with the remote skeletonization branch somehow, so I should somehow pull it? How do I make sure not to overwrite what I just updated?
@AnniekStok
Looks great! Few comments/suggestions.
Concept map
We are sometimes not very consistent, but if the module is not a workflow I would try to avoid "workflow-like" concepts.
Maybe rather:
To make the point that one may have pixels of different nature in the skeleton image?
Figure
Activity
Here is something wrong with the indentation (one space too much in front of Obtain):
Below you could use the
- [ ] ...
and- [X] ...
syntax instead of spelling out "select" and "deselect".Exercises
I would start with capital: Which ...
This is a case where the questions are the same for all implementations. I think this will be much better once we enable https://github.com/NEUBIAS/training-resources/issues/325, because then one can just write the questions once. I think already now, you could move the questions up into the
exercise_preface:
and only have the solutions in the exercises (even omitting the## Solution
syntax).