NEZNAMY / TAB-Bridge

Backend plugin to extend features on the proxy
31 stars 7 forks source link

Add ViaVersion handle #23

Closed luapascoal closed 1 year ago

luapascoal commented 1 year ago

Yes, I know that the TAB itself already has the ViaVersion handle, but my problem, in this case, is:

I need ViaVersion and the other Via plugins on my backend servers because my server is 1.19.4 but most players play on 1.8 so I need the plugins on the backend to improve gameplay on 1.8

With that, the TAB, which is in the bungee (since I run in multiple instances, so I need the global tablist) cannot get the player's version with ViaVersion. I saw that this can be a problem if I want to have a specific tag in Legacy versions and a nice tag in more updated versions.

I believe this feature can be enabled, for people who need it like me, and shared just like placeholders are.

Thank you for your attention.

luapascoal commented 1 year ago

(I'm a little new to Via plugins, I've been migrating to the new versions for a while and I have a network with more than 1,000 online only in 1.8, so I could be saying something very wrong)

Tanguygab commented 1 year ago

if TAB is on Bungee, it can get the player's version without Via, check /btab parse %player-version% from Bungee console and you'll see it works

luapascoal commented 1 year ago

if TAB is on Bungee, it can get the player's version without Via, check /btab parse %player-version% from Bungee console and you'll see it works

but that won't cause problems like it says on the wiki?

Tanguygab commented 1 year ago

It only causes issues if TAB is on the backend and ViaVersion is on the proxy. As long as ViaVersion is on the backend, everything's fine.

luapascoal commented 1 year ago

It only causes issues if TAB is on the backend and ViaVersion is on the proxy. As long as ViaVersion is on the backend, everything's fine.

Oh, ok. Thanks!

NEZNAMY commented 1 year ago

What issues are you currently experiencing that you believe are caused by incorrect version detection? And when does the parse command show incorrect version for players?

luapascoal commented 1 year ago

What issues are you currently experiencing that you believe are caused by incorrect version detection? And when does the parse command show incorrect version for players?

Honestly, none yet, we are testing. But I was reading the wiki and I came across the warning asking to use via version

NEZNAMY commented 1 year ago

Which one? There is only one against VV on Bungee, nothing else.

luapascoal commented 1 year ago

Which one? There is only one against VV on Bungee, nothing else.

Whats the problem?

NEZNAMY commented 1 year ago

But I was reading the wiki and I came across the warning asking to use via version Where does the wiki warn you and tell you to use viaversion?