search

NEZNAMY / TAB-Bridge

Backend plugin to extend features on the proxy
31 stars 7 forks source link

[Improvement/Bug] Allow in config to change if the plugin warns about inefficient placeholders #27

Closed ryzech closed 1 year ago

ryzech commented 1 year ago

Currently every time a placeholder refresh is over a certain threshold in time, it sends a warn message to the console, this can fill up log files very quickly, and in my case i'm not worried about the time it takes as it does work regardless.

image

I'm not 100% certain where this is in code, but it should be easy enough to only display if it's enabled in a config file (which would also have to be created.)

NEZNAMY commented 1 year ago

The problem is that if I don't do this, people will come crying that the plugin isn't refreshing placeholders. Since a command like /tab cpu is not available on the bridge, you have no way to know which placeholder is killing it. I spent days trying to figure it out for incompetent users in a ticket when this wasn't a thing, only to get them back in a few days later because they added the faulty placeholder back to their configs. With the recent move of placeholder refreshing off of the thread that processes other things this would not be as fatal, but it still can be, especially if a placeholder takes seconds to respond (since initial placeholder values are refreshed in processing thread).

You can use a plugin like ConsoleSpamFix to filter out these messages if you have no interest in getting your plugins fixed.

ryzech commented 1 year ago

I see, that makes sense so fair enough, thank you!