search

NEZNAMY / TAB-Bridge

Backend plugin to extend features on the proxy
31 stars 7 forks source link

Name tag doesn't show or hide as excepted with bridge #33

Closed MATRIX-feather closed 3 months ago

MATRIX-feather commented 6 months ago

The code we used to hide/show the name tag: TabAdapter.java#L39

The tag hides as expected when TAB is only installed on the server:

https://github.com/NEZNAMY/TAB-Bridge/assets/55654482/b4053a6a-662b-491a-b5dd-8ea47a23c09c

But it sometimes doesn't when TAB is installed on both sides (proxy and the server), and the bridge on the server:

https://github.com/NEZNAMY/TAB-Bridge/assets/55654482/4faf9950-88f2-4c60-9033-a0e9a0c3108b

NEZNAMY commented 6 months ago

Your code is clearly bukkit code. Are you sure you are calling it the proxy where TAB is installed as well?

MATRIX-feather commented 6 months ago

Well, the code itself doesn't interact with the proxy, and it runs on the backend server.

No, it doesn't call TAB installed on the proxy directly.

edit: I tried calling the hide method for TAB on the proxy through a plugin later, and it doesn't work either.

NEZNAMY commented 6 months ago

Show your code. This has nothing to do with bridge however.

MATRIX-feather commented 6 months ago

Sure: https://gist.github.com/MATRIX-feather/9601cad897dcfa91589bc07a921b87de

NEZNAMY commented 6 months ago

Try on BungeeCord. Also are you sure the code went through and the player or nametag manager are not null?

MATRIX-feather commented 6 months ago

Try on BungeeCord.

BungeeCord also seems to have this issue. FeatherMorphBungee.java image 6b8cdecde0d2e9c4e5c4ee8b89b2d027

Also are you sure the code went through and the player or nametag manager are not null?

Yes. 27c8d1ec9a76e29c3e176c60051746a4

NEZNAMY commented 6 months ago

Disable unlimited nametag mode.

MATRIX-feather commented 6 months ago

Disabled, and the tag hides as expected

NEZNAMY commented 6 months ago

Does it work with backend installation instead of proxy?

MATRIX-feather commented 6 months ago

Yes, it works with the backend, but on proxy it doesn't

NEZNAMY commented 3 months ago

Unlimited nametag mode was marked for removal and no more bugs will be fixed. See https://gist.github.com/NEZNAMY/f4cabf2fd9251a836b5eb877720dee5c for more info.