search

NEZNAMY / TAB-Bridge

Backend plugin to extend features on the proxy
31 stars 7 forks source link

Move from Maven to Gradle #9

Closed JT122406 closed 1 year ago

JT122406 commented 1 year ago

This is first step in a port to allow support for other platforms with the first in mind being Fabric as it has a PlaceHolderAPI type mod available first step before this port is moving the build to Gradle

NEZNAMY commented 1 year ago

Does maven not allow to implement fabric support?

JT122406 commented 1 year ago

Does maven not allow to implement fabric support?

From what I know both fabric and forge require Gradle

BomBardyGamer commented 1 year ago

This looks good to me. I think we will probably need to make this a multi-module project at some point to add platform support, but this PR is a good start. Also, I see that the build has failed, and I believe this is likely because you are a Windows user and you probably don't use the gradlew executable, which is why you've never noticed this. I don't think you can set executable permissions on Windows, but I can try and do it my end and push to this PR, don't know how well it will work though.

BomBardyGamer commented 1 year ago

Sorry this went a bit weird. Was trying to push my commit to your main branch and it seemed to reset everything, but fear not, I just pushed the changes to the upstream anyway, so the pull request is merged.