NEZNAMY / TAB

"That" TAB plugin.
Apache License 2.0
904 stars 246 forks source link

[MiniMessage] <bold> not working outside gradient #1252

Closed dasavick closed 7 months ago

dasavick commented 8 months ago

Server version

Paper 1.20.4 build 454

TAB version

4.1.3 #2ff30dd

Describe the bug

1.20.3+ - Text not bold Since 1.20.3 text configured to be bold (using &l) may not appear bold. Steps to reproduce are currently unknown, if you have any information that may help, let us know

I had both working and not working groups in my setup. I figured out that the difference was the working gradients were ending with a standard non-hex color. Then I figured out that when I swap and use bold inside gradient instead of gradient inside of bold, the bold works with hex:hex gradients also.

<bold><gradient:#aa0000:red>HELLO1</gradient> </bold> works fine. <bold><gradient:#aa0000:#ee2222>HELLO2</gradient> </bold> loses bold. <gradient:#aa0000:#ee2222><bold>HELLO3</bold> </gradient> works fine.

I was able to reproduce the issue in tabprefix/tabsuffix on vanilla 1.20.4 client with fresh build of Paper (1.20.4 build 454) and TAB (4.1.3 #2ff30dd). No other plugins installed, all default configs.

Expected behavior

Bold gradient should work in all described cases.

Steps to reproduce

  1. /tab player NAME tabprefix <bold><gradient:#aa0000:red>HELLO1</gradient> </bold>
  2. /tab player NAME tabprefix <bold><gradient:#aa0000:#ee2222>HELLO2</gradient> </bold>
  3. /tab player NAME tabprefix <gradient:#aa0000:#ee2222><bold>HELLO3</bold> </gradient>

Additional info

Apparently I found another bug while testing this: https://github.com/NEZNAMY/TAB/issues/1253

I'm not sure about this one, but I noticed something weird going on with my only hex:color, seems to behave incorrectly in tagprefix, at least in unlimited mode. Needs further testing as I recall something similar from dev env that was gone after a restart:

image

After testing a bit, I'm not sure if this is even related, as tested with exact same pattern as one working at the time of testing, the issue is still present. Still pretty weird, this one doesn't want to resolve minimessage, but resolves hex colors instead.

image

Confirmed the issue is still present after a restart. I'm gonna just leave it here for now, for a chance this is related.🤷

Checklist