NEZNAMY / TAB

"That" TAB plugin.
Apache License 2.0
904 stars 246 forks source link

[Unlimited Nametags] nametag remains at sneak position when no longer sneaking #1290

Closed NoriusCodes closed 5 months ago

NoriusCodes commented 6 months ago

Server version

purpur 1.20.4

TAB version

4.1.4

Plugin list

Describe the bug

When the player sneaks, sometimes the armorstand above his head remains in the sneak position and stays gray. Here some pictures: 2024-05-20_16 49 37 2024-05-20_16 49 43

Expected behavior

The nametag should remain over the player head and should not have the sneak effect.

Steps to reproduce

sneak and move

Additional info

Im running the server on purpur 1.20.4

Checklist

NEZNAMY commented 6 months ago

Unfortunately I have decided to remove this feature from the plugin after considering all pros and cons. Once MC 1.21 hits, I will make a bigger announcement, as well as planned removal date. For the time being, bug reports in this feature will no longer be accepted.

NoriusCodes commented 6 months ago

In my opinion it is one of the best features in the plugin. Why do you want to remove it? Yes, there are many disadvantages, but I believe that the advantages and the possible applications that it enables clearly predominate. You made this feature almost perfect. Your plugin is the only one with this feature and I think that is why it is so popular.

To the bug: Do you have any idea why this bug occurs and how it could be fixed? Could it be related to the version?

NEZNAMY commented 6 months ago

There are many bugs which I have no idea how to fix and most of the limits the game had were removed in recent versions, making the feature even less useful. It is also hard to maintain, since it's a lot of extra code, especially with entities, that needs to be maintained and updated. I have no idea how to fix this one either.

NoriusCodes commented 6 months ago

I understand your point. At a certain point, the complexity it brings is no longer worth it.

NEZNAMY commented 5 months ago

Unlimited nametag mode was marked for removal and no more bugs will be fixed. See https://gist.github.com/NEZNAMY/f4cabf2fd9251a836b5eb877720dee5c for more info.