Disable condition does not work as it's expected on velocity

MatinHQ commented 4 months ago

Server version

velocity build #390

TAB version

4.1.5

Plugin list

Not required in this case

Describe the bug

I have config below in my velocity tab and I don't want my bedwars servers get formatted by velocity tab however it doesn't behave as it's expected it still tries to override my bedwars custom tab formating

when i set anti-override to false, it would work as it's expected as bedwars tab formatting would be able to override tablist name formating

tablist-name-formatting:
  enabled: true
  anti-override: true
  disable-condition: '%server%=bedwars-1|%server%=bedwars-2'

Expected behavior

It shouldn't handle tab format on disabled-condition as it's expected

Steps to reproduce

Put tab jar in velocity
enable tab formating and make sure anti-override is also enabled
run a spigot server which have custom tab format (ex: bedwars)
in velocity tab format disable-condition add the server name so tab doesn't override the name tag

it doesn't work and tab still tries to override tab format on disable-condition server there is doc tape fix to disable anti-override

Additional info

No response

Checklist

[X] I am running latest version of the plugin
[X] I have read the wiki to make sure it's not an issue with configuration
[ ] I ticked all of the boxes without actually reading them
[X] I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform
[X] I am willing to cooperate to get this issue resolved faster, including providing any additional information requested or testing new builds

NEZNAMY commented 4 months ago

What build of the plugin are you using? I fixed something I accidentally broke previously in build 1130.

MatinHQ commented 4 months ago

Actually i already read your commits before opening this issue to see if it got fixed before I report that

and i am well aware of this commit also I updated to latest dev build again yesterday but issue still persist however I have to mention I didn't update tab on my backend servers can this be the issue?

NEZNAMY commented 4 months ago

Mixed installation is unsupported. Why would you use it?

MatinHQ commented 4 months ago

long story short, we have separate luckperm database for some of game modes for example roleplay as it's have more than 100 groups (also it would get more as people create gangs and..) so we handle name format there spigot side

NEZNAMY commented 4 months ago

So on bedwars you are using the plugin on backend for tablist formatting? And the issue is that the backend doesn't properly apply format on join?

MatinHQ commented 4 months ago

So on bedwars you are using the plugin on backend for tablist formatting? And the issue is that the backend doesn't properly apply format on join?

yes unless i change anti-override to false on proxy even tho i have bedwars servers disabled on disabled-condition on proxy

NEZNAMY commented 4 months ago

Proxy configuration:

tablist-name-formatting:
  enabled: true
  anti-override: true
  disable-condition: '%server%=lobby2'

_NEZNAMY_:
  tabprefix: '&6&lTAB &r'
  tagprefix: '&6&lTAB &r'

Backend configuration:

_NEZNAMY_:
  tabprefix: '&6&lBackend&r &a'
  tagprefix: '&6&lBackend&r &a'

When in lobby: After using /server lobby2:

Using latest build from actions. I am unable to reproduce your issue using provided steps.

MatinHQ commented 4 months ago

I will try with latest build once more and let you know do you have tab bridge also installed on backend or you are doing without it?

NEZNAMY commented 4 months ago

Yes I have bridge installed, but it doesn't have any effect on this issue.

xii69 commented 4 months ago

Also we've another problem about placeholders, when i try to put a placeholders in TAB Velocity on groups.yml or config.yml I get this error: https://paste.md-5.net/riverodafa.cs

NEZNAMY commented 4 months ago

Looks like you used a third party tool to dynamically reload the plugin at runtime. The class is obviously there. Try a full restart.

MatinHQ commented 4 months ago

It's fixed in the latest version. Sorry for the inconvenience; we had to update the tab on the backend servers to fix the issue

NEZNAMY / TAB