NEZNAMY / TAB

"That" TAB plugin.
Apache License 2.0
886 stars 246 forks source link

Essentials Nickname with BungeeCord & Bukkit Bridge #131

Closed schwurblig closed 4 years ago

schwurblig commented 4 years ago

I'd like to display the Essentials Nickname of the user. I'm using the plugin on BungeeCord and on Spigot, set up as Bridge. It's a Placeholder from PlaceholderAPI and I've seen Chat-Plugins with same (BungeeCord and Bukkit Bridge). What would be cool either, not just supporting LuckPerms in config.yml --> Groups, just all the Vault Plugins (or just CloudNet v2 Permissions).

NEZNAMY commented 4 years ago

If you want to use essentials nickname use a placeholderapi placeholder like %essentials_nickname%. For permission plugins, Vault hook is present on bukkit version and on bungeecord all popular permission plugins are supported directly (as Vault doesn't have bungee version).

schwurblig commented 4 years ago

Hey thanks, but how can I make TAB use the nickname, not the normal playername? I see this Option just in config.yml on Spigot Server which is in Bridge Mode. So about Vault: It works, but setting group Prefix per Group in TAB Config, doesn‘t work.

NEZNAMY commented 4 years ago

As i said, use %essentials_nickname%. Prefixes for groups work too. This is a core feature and if it didn't work, everyone would report it, not just you.

schwurblig commented 4 years ago

Hey, thanks, but where to enter %essentials_nickname%? I see no possibility in BungeeCord TAB Config.

NEZNAMY commented 4 years ago

As customtabname of groups that should use it.

schwurblig commented 4 years ago

Hey

I've tried that, but actually it doesn't work, not the Essentials Nickname, neither the Group Prefix That's my BungeeCord config.yml: https://hastebin.com/icipeworab.cs That's a screenshot from the tablist: https://prnt.sc/ruai7y That's a screenshot from the Chat (where you can see, I've set a Nickname with Essentials): https://prnt.sc/ruaizb That's my Spigot config.yml: https://hastebin.com/goqifijepa.makefile That's my Spigot advancedconfig.yml: https://hastebin.com/ifowupagek.cs

We're using Vault in combination with CloudNet v2 Permissions-Plugin. It gets normally recognized by Vault (according to /vault-info).

Greetings

NEZNAMY commented 4 years ago

Problem is likely that bungee version of the plugin doesn't have a hook into permission plugin on bukkit, which is in fact a different server often running on a different machine, which makes direct API calls not really possible.

schwurblig commented 4 years ago

The problem with the Prefix isn't that big, short Prefixes would have been better but Nicknames are more important. I don't know how to set Essentials Nickname for Tab in BungeeCord config.yml.

NEZNAMY commented 4 years ago

First make sure you actually are in developer group using /btab debug [player]. If not, that's why customtabname wasn't applied to you.

schwurblig commented 4 years ago

I guess, know we know, why it doesn't show what it should, but we don't know why it doesn't recognize my rank. https://prnt.sc/ruaw8w https://prnt.sc/ruawr8

NEZNAMY commented 4 years ago

Like i said, bungee plugin can't hook into Vault which runs on bukkit. You need a bungeecord permission plugin.

schwurblig commented 4 years ago

Well CloudNet has an API which works on BungeeCord too. I just can't code with BungeeCord.

schwurblig commented 4 years ago

Could you may add support for CloudNet? That would be real amazing.

NEZNAMY commented 4 years ago

I have no idea what it is and how to add support.

schwurblig commented 4 years ago

It is a Cloud-System with an integrated Permissions-System. It also has a documentation and is available on Github. https://github.com/CloudNetService/CloudNet https://cloudnetservice.eu/cloudnet/docs/v2.1.17/

NEZNAMY commented 4 years ago

Send me it's bungeecord jar and API method to hook into it.

schwurblig commented 4 years ago

And where should I send you the Jar? However, that's the download Link: https://ci.cloudnetservice.eu/job/CloudNetService/job/CloudNet/job/master/lastSuccessfulBuild/artifact/cloudnet-api/cloudnet-api-bridge/target/CloudNetAPI.jar I guess, here https://cloudnetservice.eu/cloudnet/docs/v2.1.17/ you're searching for Class: "PermissionModule".

schwurblig commented 4 years ago

Is that enough or do you need more information? I could test plugin then if it works (as I'm using this System obviously).

NEZNAMY commented 4 years ago

I will let you know when i try it.

NEZNAMY commented 4 years ago

This looks like a bungee fork or something, i don't know how would i possibly add support for it's permission system.

A248 commented 4 years ago

Why wouldn't CloudNet just override the BungeeCord API's Player#hasPermission? Ideally it would interoperate with existing permission checks seamlessly.

NEZNAMY commented 4 years ago

The plugin already checks for permission groups defined in bungeecord config.yml if no permission plugin is installed.

Tanguygab commented 4 years ago

in the meantime, you could just set customtabname: "%essentials_nickname%" to the _OTHER_ group so it applies to everyone without needing a group