Broken on 1.19 Waterfall while using ViaVersion on Survival/Creative servers

TomLewis commented 2 years ago

Server version

1.19 Waterfall to 1.18.2 ViaVersion

TAB version

3.1.1

Describe the bug

I cant allow 1.19 clients to connect to my 1.18.2 proxy because Tab breaks and prevents clients entering.

We have Tab 3.1.1 working on Waterfall in 1.18.2 with 1.18.2, but when I upgraded to Waterfall 1.19 while keeping my 1.18.2+ViaVersion any client 1.18 or 1.19 that connects gets errors related to Tab plugin, which is installed on the waterfall.

This is an image

This is the error from the bungee running tab, the survival is using tab bridge.

https://gist.github.com/TomLewis/949005ad5907da8e5056a1904ec98e37

Expected behavior

Not error and allow clients to connect.

Steps to reproduce

Use latest waterfall and install tab
Install tab bridge onto survival server
Have 1.18.2 PurPur survival server and install the latest ViaVersion dev version
Without Tab players can use 1.19 clients to connect to the 1.18.2 server, with tab it breaks this.

Additional info

No response

Checklist

[X] I am running latest version of the plugin
[X] I have read the wiki to make sure it's not an issue with configuration
[X] I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform

NEZNAMY commented 2 years ago

How is this not a duplicate of #611 ? Also where did you read that the plugin supports 1.19?

TomLewis commented 2 years ago

I do not get the message Your server version is completely unsupported anywhere from that other ticket. This is extra information for how to re-produce so it can be tested with screenshot that clients receve.

This also breaks 1.18.2 clients conencting too, making using 1.19 waterfall fully unusable.

Is this being worked on? I dont want to have to remove tab just to allow 1.19 clients to connect.

NEZNAMY commented 2 years ago

https://github.com/NEZNAMY/TAB/issues/611#issuecomment-1150098058

TomLewis commented 2 years ago

Best I submit information if its useful, my case differs in the fact im unsing a bungee setup.

NEZNAMY commented 2 years ago

Bungeecord had a breaking change that requires a plugin update.

SueFox commented 2 years ago

Hey! I also have the same problem, when I upgrade waterfall to 1.19-496, the player will get the error in the screenshot above as soon as the player enters. Even if I delete all other plugins and leave only Tab (I'm using the release version 3.1.1, and I'm using translation software, there may be inaccuracies)

SueFox commented 2 years ago

At the same time, an error will also appear on my client, which may help you to fix this bug (but it will not cause the game to be closed directly) https://pastes.dev/cNpwDiyDy9

SueFox commented 2 years ago

Oh. . . I tried the latest plugin (#397), although the player will not be kicked out immediately after entering and display an error, but it will make the plugin unable to run normally (the tab and scoreboard cannot be displayed), and an error is thrown in the backstage: https://pastes.dev/XWtgE8trau

NEZNAMY commented 2 years ago

For the n-th time: Latest public TAB release (3.1.1) does not support 1.19.

NEZNAMY commented 2 years ago

Use the plugin on paper 1.12.2 if you want to, but that error comes from unsupported version of bungeecord, not paper.

SueFox commented 2 years ago

Use the plugin on paper 1.12.2 if you want to, but that error comes from unsupported version of bungeecord, not paper.

(The annoying language is not interoperable...) I try to understand your reply by myself, do you mean that the current tab does not support Waterfall 1.19 or Paper 1.19?

NEZNAMY commented 2 years ago

Exactly! https://github.com/NEZNAMY/TAB/wiki/Compatibility#supported-server-versions

SueFox commented 2 years ago

确切地！https://github.com/NEZNAMY/TAB/wiki/Compatibility#supported-server-versions

Exactly! https://github.com/NEZNAMY/TAB/wiki/Compatibility#supported-server-versions

Oh. . . I didn't pay attention to the wiki, I just thought they were forks of these cores so it shouldn't cause problems. . . But the Waterfall I have been using before has no problems with the Paper. . . If it's because of the core, then I'll have to change waterfall back to the old version and try to wait for the update (maybe this is an official problem) I will try Spigot with Bungeecord Thank you for your help! This question bothers me probably. . . 5 hours?

TomLewis commented 2 years ago

Shall I just remove tab for now if this is going to take a long time? I need 1.19 clients to be able to connect. I can see https://github.com/NEZNAMY/TAB/milestone/19 3.1.2 is planned, are those all seperate issues that need to be solved?

NEZNAMY commented 2 years ago

Those are issues that will be solved in the next update.

TomLewis commented 2 years ago

Thank you! good job! I got this live 20 mins ago and we now have 1.19 clients connecting!

NEZNAMY / TAB