search

NEZNAMY / TAB

"That" TAB plugin.
Apache License 2.0
904 stars 246 forks source link

Player nameplate overlapping with TAB armorstands #884

Closed JpegIsMe closed 1 year ago

JpegIsMe commented 1 year ago

Server version

Purpur 1.19.2 w/ Velocity Proxy

TAB version

3.3.2

Describe the bug

The vanilla player nameplate overlaps with the TAB armorstands, making a garbled mess of text on the bottom most row, and showing the player's name twice. This gets fixed for just a moment if you reload the plugin, but reverts back to the bugged version after a second or two.

image

Expected behavior

Vanilla nameplate shouldn't be there

Steps to reproduce

  1. Have a Velocity Proxy with a Purpur 1.19.2 server
  2. Install TAB and enable the armorstand nameplate feature

Additional info

This is the only issue we're facing with TAB, other than that, it runs perfectly fine on Velocity.

Log for /tab debug: https://pastebin.com/LLz7cNvb Config.yml: https://pastebin.com/pymAbgbd Groups Config: https://pastebin.com/y8R3LDRr

Checklist

NEZNAMY commented 1 year ago

3.0.2 is absolutely not latest. Send your config.yml and output of /tab debug <player>.

JpegIsMe commented 1 year ago

3.0.2 is absolutely not latest. Send your config.yml and output of /tab debug <player>.

Apologies, I misremembered, we're running 3.3.2 Updated the bug report

JpegIsMe commented 1 year ago

@NEZNAMY Log for /tab debug: https://pastebin.com/LLz7cNvb

Config.yml: https://pastebin.com/pymAbgbd And just in case, the groups config: https://pastebin.com/y8R3LDRr

NEZNAMY commented 1 year ago

Send plugin list. It is very likely to be caused by another plugin. Try removing plugins until it's fixed.

JpegWasMe commented 1 year ago

Will get to this tomorrow

JpegIsMe commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

4drian3d commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

Use only Velocitab or install TAB in Velocity and TAB-Bridge in your servers

JpegIsMe commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

Use only Velocitab or install TAB in Velocity and TAB-Bridge in your servers

When I try and do this I am met with the following error: https://pastebin.com/fAFPw7Wv

4drian3d commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

Use only Velocitab or install TAB in Velocity and TAB-Bridge in your servers

When I try and do this I am met with the following error: https://pastebin.com/fAFPw7Wv

Use the latest build from GitHub Actions https://github.com/NEZNAMY/TAB/actions/runs/4877345120

JpegIsMe commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

Use only Velocitab or install TAB in Velocity and TAB-Bridge in your servers

When I try and do this I am met with the following error: https://pastebin.com/fAFPw7Wv

Use the latest build from GitHub Actions https://github.com/NEZNAMY/TAB/actions/runs/4877345120

Okay got TAB working on velocity proxy, but we're still having the same issue with velocitab. Remember that reloading TAB briefly fixes it, until velocitab updates. javaw_PUxKB1Og1y

Frerduro commented 1 year ago

Issue is on velocitab git issues also, Hopefully this issue can be resolved. WiIIiam278/Velocitab#54

4drian3d commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

Use only Velocitab or install TAB in Velocity and TAB-Bridge in your servers

When I try and do this I am met with the following error: https://pastebin.com/fAFPw7Wv

Use the latest build from GitHub Actions https://github.com/NEZNAMY/TAB/actions/runs/4877345120

Okay got TAB working on velocity proxy, but we're still having the same issue with velocitab. Remember that reloading TAB briefly fixes it, until velocitab updates.

If you are already using TAB in Velocity, there is no reason for you to have Velocitab installed

Tanguygab commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

have you tried disabling sorting? It does seem to have a check for the option to load the feature or not https://github.com/WiIIiam278/Velocitab/blob/master/src/main/java/net/william278/velocitab/Velocitab.java#L144-L149

JpegIsMe commented 1 year ago

Alright, turns out the issue was caused by the plugin velocitab, a velocity tablist plugin. I set all its settings to false but to no avail. Will get in contact with its dev, and I'll keep you updated with what happens.

have you tried disabling sorting? It does seem to have a check for the option to load the feature or not https://github.com/WiIIiam278/Velocitab/blob/master/src/main/java/net/william278/velocitab/Velocitab.java#L144-L149

Not on PC as of right now, but I can pretty confidently say that I had set everything to 'false' in the provided config.yml of Velocitab.

Regarding the other comments, I will consider switching from velocitab to TAB for tablists, but I'd like to see what the velocitab dev has to say regarding this compatability issue before comitting to the switch.

WiIIiam278 commented 1 year ago

Hi -- both plugins are modifying user profile displays on the proxy layer to achieve this above/below name stuff, so this isn't affected by the scoreboard packet stuff I'm doing (i.e. disabling sorting won't have an affect). In short, TAB is clearing the profile display name to hide it, so it can be replaced with fancy armor stands to achieve the effect (I think), and my plugin is setting it so it shows up nicely in the tab menu.†

†oversimplification, but I think this is the gist of what's happening.

This is an unavoidable incompatibility with this feature of TAB I think -- and I think the TAB developer would agree there's not much point working to achieve compatibility between two plugins competing to offer the same functionality :) I think this issue can be closed and a note made in both mine and Nezamy's documentation about this compatibility issue.

Warm regards

Tanguygab commented 1 year ago

Hiding nametag is done through scoreboard team packets though?

Tanguygab commented 1 year ago

Here, you're setting nametags to always show in your team packets https://github.com/WiIIiam278/Velocitab/blob/master/src/main/java/net/william278/velocitab/packet/UpdateTeamsPacket.java#L65 So we just need to disable team packets from being sent or you could maybe add an option to always hide nametags in your config

WiIIiam278 commented 1 year ago

Oh, it is? Well, if @JpegIsMe would like to test out making sure they've disabled sorting, I don't see why it wouldn't work. Velocitab hooks into Velocity internals to dispatch scoreboard packets. The display name flag is not hidden in those packets.

https://github.com/WiIIiam278/Velocitab/blob/master/src/main/java/net/william278/velocitab/packet/UpdateTeamsPacket.java

WiIIiam278 commented 1 year ago

Here, you're setting nametags to always show in your team packets WiIIiam278/Velocitab@master/src/main/java/net/william278/velocitab/packet/UpdateTeamsPacket.java#L65 So we just need to disable team packets from being sent or you could maybe add an option to always hide nametags in your config

That's possible, sure, but I'd like to make sure it is related to the scoreboard packet logic here -- OP is saying they have all this stuff turned off in their config, and so long as sorting is disabled I don't do any scoreboard packet stuff.

Tanguygab commented 1 year ago

Displayname doesn't affect nametags, and yeah I agree that it should have worked when disabling sorting, I don't know why it's still happening, so that's why I was thinking about adding an option to change the NametagVisibility

Maybe they forgot to reload/restart the proxy or save the file? Unsure

NEZNAMY commented 1 year ago

Having 2 plugins handle teams will not work. User must choose which plugin will they use for teams and disable them in the other one. If "disabling" teams in velocitab doesn't actually disable them, it's a bug in the plugin which should be reported to them, not here. Closing this as this is not a TAB issue.