NEvans85 / Arcane-Laboratory

Deck Builder Web Application for the CCG Magic the Gathering. FSP for App Academy
2 stars 0 forks source link

PA Review #29

Closed NEvans85 closed 6 years ago

NEvans85 commented 6 years ago

The deck view functionality is pretty much there. I second guess my color scheme, I keyed the element colors off of the background which is a little less blue than my others. However, this is similar to the pale yellow used in my card search. The comments will live at the bottom of this page but are a separate MVP.

s-pangburn commented 6 years ago

Created By: User8 about 17 hours ago, Last Updated about 17 hours ago, Upvotes: 15 This looks a little messy, maybe separate creation date and author into two separate fields? Also, Try using bold fonts or a fancier font for the titles and labels, similar to https://magic.wizards.com/en/ - Notice how headers and titles are bolded and in all-caps to separate them from the body content. This helps make it easier for the user to separate them in their mind, which in turn makes it easier to read. Try to think of the page content in terms of heirarchy, and style your elements according to that heirarchy. Major elements like headers should have the most "weight" on the page, while details like author information or date created should have very little.

So, in summary:

Things to fix

  1. Try to make your headers bold or in some way more distinct, give them "weight" and think of your page content in terms of heirarchy.

  2. I think it might spice up the deck view some more if each category of card (Lands, Creatures, Planeswalkers, Artifacts) had a distinct color for its box. It's easy to overdo it in this case, so I recommend tending towards muted, darker colors or at least desaturated. Nothing too bright. However, I think it would be a good way to make the deck view less brown, and also add a bit of character to each deck where the proportion of each color changes based on the composition. Also, add a smidge more padding on the left and right sides of the card lists.

  3. Reorganize the user and date information to be easier to read. Using bold and other ways of visually organizing the data might help here. Also, I feel like it should be centered.

s-pangburn commented 6 years ago

Make sure to get around to this feedback before the end of the day, particularly the titles and the date information, the colors aren't necessary!

NEvans85 commented 6 years ago

I bolded the title but the description is being difficult.

NEvans85 commented 6 years ago

I think I broke my webpack when following the production-ready instructions

s-pangburn commented 6 years ago

Checking it this morning, it looks good, and it seems like your heroku is running fine at this time. Let me know if you need additional assistance down the line regarding these or other issues, but I think what's here is perfectly good for now. I'll mark this issue complete!

Thank you for all your hard work Nick!