search

NFDI4BIOIMAGE / training

https://nfdi4bioimage.github.io/training
Creative Commons Attribution 4.0 International
12 stars 7 forks source link

Debug the normalizer.py #474

Open SeverusYixin opened 1 week ago

SeverusYixin commented 1 week ago

some licenses like "bsd 3-clause" not be normalized, check it and update the code.

SeverusYixin commented 1 day ago

Hi @haesleinhuepf, The original script only normalized the data, while book.yml and test.yml simply called this function without performing additional operations, such as upgrading. For details on the upgrade operation, refer to PR #511

There are two questions:

  1. Should the process of creating a pull request (PR) be handled within data_normalizer? Would this approach be safer?

  2. Regarding the author fiel: e.g. authors: ‘Fabig, Gunar, Jannasch, Anett, Okafornta, Chukwuebuka, Boissonnet, Tom, \ Schmidt, Christian, Bortolomeazzi, Michele, Fuchs, Vanessa Aphaia Fiona, Koeckert, \ Maria, Poddar, Aayush, Vogel, Martin, Schwarzbach, Hanna-Margareta, Vogelsang, Andy, Gerlach, Michael, Nobst, Anja, Müller-Reichert, Thomas, Tulok, Silke’

    in line https://github.com/NFDI4BIOIMAGE/training/blob/089c26a86a6625499809be0955ce58977251a757/resources/nfdi4bioimage.yml#L6935 Was this list generated automatically? How can it add something like "\"?

SeverusYixin commented 1 day ago

Also this one "https://github.com/NFDI4BIOIMAGE/training/blob/089c26a86a6625499809be0955ce58977251a757/resources/nfdi4bioimage.yml#L6300". How was it added? Why is it so different from the original website format?

haesleinhuepf commented 23 hours ago
  1. Should the process of creating a pull request (PR) be handled within data_normalizer?

Yes! It would also to easier to read in Python.

How was it added? Why is it so different from the original website format?

Have you tried out git blame? You can click on the line number next to the code and read which commit added the code and who did it. Give it a try!

SeverusYixin commented 6 hours ago
  1. Should the process of creating a pull request (PR) be handled within data_normalizer?

Yes! It would also to easier to read in Python.

OK :)

How was it added? Why is it so different from the original website format?

Have you tried out git blame? You can click on the line number next to the code and read which commit added the code and who did it. Give it a try!

It looks like automatic add by the zenodo links, then this is a new data format, I will also create a rule for it