NFDI4Chem / VibrationalSpectroscopyOntology

WORK IN PROGRESS - The Vibration Spectroscopy Ontology defines technical terms with which research data produced in vibrational spectroscopy experiments can be semantically enriched, made machine readable and FAIR.
https://nfdi4chem.github.io/VibrationalSpectroscopyOntology/
Creative Commons Attribution 4.0 International
7 stars 7 forks source link

[NTR] add "spectral window range: minimum" and "spectral window range: maximum" #31

Closed Zack-83 closed 1 year ago

Zack-83 commented 1 year ago

Preferred term label

spectral window range minimum and spectral window range maximum

Synonyms

acquisition band minimum & acquisition band maximum

Textual definition

A data item that is the part of a Raman spectrum which represents the maximum/minimum wavenumber included in the spectrum and which is calculated from the windows size and window center.

Suggested parent term

IAO:data item

Examples

spectral window range minimum = 210 cm^−1 spectral window range maximum = 1960 cm^−1

Attribution

ORCID:0000-0001-7694-5519

StroemPhi commented 1 year ago

@Zack-83 is this a quality/attribute of the spectrum or a setting of the spectroscopy?

Zack-83 commented 1 year ago

It is an attribute of the spectrum.

StroemPhi commented 1 year ago

grafik @Zack-83 do I understand you correctly, that the two terms you request here are parts of the data item (information) that is the Raman spectrum and which refer to the lower and upper bounds of the X-axis which represents the wavenumber?

And if so, my next question would be: Are the "window size" and "window center" from which they get calculated the output of a data transformation on the initially detected signal or are they determined by a setting of the Raman spectrometer itself?

Zack-83 commented 1 year ago

Yes, "minimum" and "maximum" belong to the spectrum and refer to that axis in the diagram. (Of course it is not the spacial X-axis, but the horizontal axis of a spectrum diagram.)

Even "window size" and "window center", expressed as wavenumbers, are not really primitive instrumental parameter; to my knowledge they are calculated based on window center wavelength, excitation wavelength and groove density (or an equivalent quantity such as window size as wavelength or wavelength-related spectral resolution).

@RainerStosch @Stefano-Luin feel free to correct / complement.

StroemPhi commented 1 year ago

If I understand correctly, we then also need to mint "window size as wavelength" and "window center wavelength", right? And by looking at the data example you provided, I would assume that an example of the former is Raman spectroscopy aqueous solution setup.yml#L29 and of the latter Raman spectroscopy aqueous solution setup.yml#L28. Is that correct?

Zack-83 commented 1 year ago

Yes, there they are.
Probably we don't need to mint everything... It depends on the scope.
If the scope is to make experimental results searchable, comparable and combinable with others, then we need a limited amount of parameters and thus of classes.
If the scope is to document the experimental procedure to make it reproducible, then we need to define the settings in a way which is univoquely implementable for present, past and future setups.
I suppose that the first scope is easier to implement.

StroemPhi commented 1 year ago

The reason for me asking to also mint these is rooted in the textual definition you provided: "[...] calculated from window size and window center."

Regarding VIBSO's scope, so far we have it defined broad enough here to also include the reproducability aspect, which I think is implied in the IR of FAIR data. But VIBSO's development is an incremental process and to be also a managable one, I agree that we need to focus on one thing after another, e.g. findability first. For this it is necessary to regularly check and update the competency questions, as they can be used as kind of unit tests for the expressiveness of the ontology. So I'd love to get feedback from you with regard to what kind of questions do you experts consider the most important atm. Like when you say "relevant for searching/comparing", please try to formulate a competency question. Maybe in this example it would be something along the lines of: "What is the window range minumum and maximum of the Raman spectrum produced by the Raman assay X that implements Raman spectroscopy method Y?"

related to: #54

StroemPhi commented 1 year ago

To switch the focus back on the two terms requested in this issue, is this aquisition band parameter providing examples for the minimum (210 cm^−1) and maximum (1960 cm^−1) spectral window range?

Zack-83 commented 1 year ago

To switch the focus back on the two terms requested in this issue, is this aquisition band parameter providing examples for the minimum (210 cm^−1) and maximum (1960 cm^−1) spectral window range?

Exactly.

As you can see, my description example has potential for improvement :)

I agree with you, we should have a look at the competency questions. Together with our experts.

I tried to reconstruct the formulas to calculate the minimum and maximum wavenumbers of the spectral window:

$$ \bar\nu\min = \frac{1}{\lambda\mathrm{exc}} - \frac{1}{\lambda_\mathrm{center}+\Delta\lambda/2} $$

$$ \bar\nu\max = \frac{1}{\lambda\mathrm{exc}} - \frac{1}{\lambda_\mathrm{center}-\Delta\lambda/2} $$

I beg the experts to check.

StroemPhi commented 1 year ago

Hi @Zack-83, in #55 I added the requested two terms, without introducing the possible classes on which they are based. But I added an editor note referring to the possible need for minting these later.