NFDI4Chem / rxno

Name Reaction Ontology
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

Improvement of RXNO documentation #9

Closed hujo91 closed 3 years ago

hujo91 commented 3 years ago

This issue arises from #6 and focuses on inconsistencies in the documentation stored for RXNO. This makes it difficult to contribute, e.g. by adding new reactions.

hujo91 commented 3 years ago

Following significant errors or difference between the graphical RXNO reaction assignment flowchart of the poster and the written version of the flowchart complicate the clear class assignment when adding a new reaction:

hujo91 commented 3 years ago

A revised graphical flowchart: flowchart_reaction_corrected has been created from the original graphical RXNO reaction assignment flowchart of the poster with regard to the above-mentioned errors, and the changes made in this process have been highlighted in purple in a separate figure. flowchart_reaction_corrected_marked

hujo91 commented 3 years ago

For the determination of the skeleton, only a written scheme exists so far. On this basis, a new graphical flowchart was created. flowchart_skeleton_new

hujo91 commented 3 years ago

to be take care of: In the RXNO documentation any guidelines are missing in which way a contributor should import already existing terms (e.g. substance classes) from other ontologies (e.g. CHEBI) if necessary for adding new reactions. This is one aspect of the insufficient RXNO documentation for contributors.

hujo91 commented 3 years ago

86f6e88

hujo91 commented 3 years ago

ba97794

hujo91 commented 3 years ago

74c0f09

hujo91 commented 3 years ago

b92a372

hujo91 commented 3 years ago

@andrecastro0o & @StroemPhi I have completed all the remaining adjustments and think that https://github.com/rsc-ontologies/rxno/pull/15 can now finally go to Colin.

hujo91 commented 3 years ago

f599a86 this finally as a smaller change for the eye

hujo91 commented 3 years ago

closed with merge of PR https://github.com/rsc-ontologies/rxno/pull/15