search

NFDI4Microbiota / nfdi4microbiota-knowledge-base

The NFDI4Microbiota Knowledge Base
https://nfdi4microbiota.github.io/nfdi4microbiota-knowledge-base/
Creative Commons Attribution 4.0 International
24 stars 26 forks source link

Invalid URLs in Markdown files #179

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 4 months ago

Errors in docs/_How-We-Operate/00-N4M-intro.md

This content was produced by a GitHub Action.

babs1984 commented 4 months ago

Hi Charlie,

thanks, I just fixed the broken URLs that are not Nextcloud links. The Nextcloud links should not be accessible for externals, only for members that have a user profile and access to our Nextcloud. I tried to hide confidential information behind those links.

Do you think it is unsafe? Konrad wanted a how we operate that is rather open, like for the carpentries or git.

cpauvert commented 4 months ago

Do you think it is unsafe? Konrad wanted a how we operate that is rather open, like for the carpentries or git.

No no! Open and transparent is what I also want, I did not know that you needed to have an account to access the documents. I thought that there was a way to make them (or some of them) public (meaning without account needed).

In that case, we might need to add those URLs to the ignore file as in 7bb439c400fca73c42ac0a3f86c17272dca5472b otherwise the bot will not stop complaining (as :robot: cannot create a nextcloud account in this case)

cpauvert commented 4 months ago

[!TIP] File > Share > Share Link in Nextcloud for better formatted and persistent URLs!

:arrow_up: : This is my suggestion for nextcloud file sharing, instead of copy-pasting the displayed URL, as this can create issues, for instance, some links above have index.php in the URLs which is usually bad practice.

So the first link https://nextcloud.nfdi4microbiota.de/index.php/f/105621 would be https://nextcloud.nfdi4microbiota.de/s/WbRjYnS23W6ib2y instead.

THe interface to copy the persistent URL looks like below:

image

could be useful @babs1984 as you going to edit and change the links ; )

babs1984 commented 4 months ago

Hi Charlie,

thanks for pointing me to this! I guess the index thing was before I changed my sharing practice to the one you explained above. I normally click on the 'internal link' in the sidebar under sharing, as this link can only be accessed by users that can login to Nextcloud. I even wrote a policy on that :) https://nextcloud.nfdi4microbiota.de/f/105664

image

I will go through the document now and have a look at the links, correct them and try to follow the other procedure to avoid the bot problem.

Thanks a lot for your support Charlie!