search

NFIBrokerage / slipstream

A slick WebSocket client for Phoenix Channels
https://hex.pm/packages/slipstream
Apache License 2.0
160 stars 18 forks source link

handle_topic_close/3 becomes handle_leave/2 for leaves? #33

Closed the-mikedavis closed 3 years ago

the-mikedavis commented 3 years ago

in the implementation, leaves are certainly different than topic closes

it seems most implementations would treat leaves differently than topic closes, so I think it makes sense to have a c:Slipstream.handle_leave/2 separate from c:Slipstream.handle_topic_close/3

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.