NFIBrokerage / slipstream

A slick WebSocket client for Phoenix Channels
https://hex.pm/packages/slipstream
Apache License 2.0
155 stars 18 forks source link

add :telemetry for clients #4

Closed the-mikedavis closed 3 years ago

the-mikedavis commented 3 years ago

instrumentation with telemetry could be valuable, but I'm not sure what events we would want to emit

what questions would we be trying to answer with telemetry?

the-mikedavis commented 3 years ago

see the guide from Phoenix.Logger: https://hexdocs.pm/phoenix/Phoenix.Logger.html

the-mikedavis commented 3 years ago

~there's probably a good argument to make for splitting out (by event type) telemetry for the connection process and telemetry for the client~

see #13

this issue now only pertains to the client's telemetry

the-mikedavis commented 3 years ago

this is really probably not as hard as I would imagine off the bat...

still some open questions that can be revisited later: