NFIBrokerage / spear

A sharp EventStoreDB v20+ client backed by Mint :yum:
https://hex.pm/packages/spear
Apache License 2.0
85 stars 14 forks source link

Fixes typespecs for Spear.read_stream/3 #81

Closed kristofka closed 1 year ago

kristofka commented 1 year ago

Minor typespec correction, allowing to pass the :all atom to Spear.read_stream/3. The functionnality is already supported, this just fixes the spec.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2e6a7eedc6fe2bf922a61a236c708747e6604a42-PR-81


Totals Coverage Status
Change from base Build 1e5439e5b3c2089d023eb6e3bdcdeb65a9497a21: 0.0%
Covered Lines: 697
Relevant Lines: 697

💛 - Coveralls
kristofka commented 1 year ago

Ah good catch thanks. At some point it would be nice to add dialyzer to the CI too so maybe it could find things like this

Yes, that would be nice. I’ve found a couple more places where dialyzer gave me warnings (I guess at first the stream name couldn’t be :all). I’ll open a new PR for those, if it’s ok with you. It’s not a big deal, but it’s always better not to have dialyzer warn against things that actually work.

(Unrelated side note, volley’s doc is great, thank you for that).