Closed kristofka closed 1 year ago
Totals | |
---|---|
Change from base Build 1e5439e5b3c2089d023eb6e3bdcdeb65a9497a21: | 0.0% |
Covered Lines: | 697 |
Relevant Lines: | 697 |
Ah good catch thanks. At some point it would be nice to add dialyzer to the CI too so maybe it could find things like this
Yes, that would be nice. I’ve found a couple more places where dialyzer gave me warnings (I guess at first the stream name couldn’t be :all). I’ll open a new PR for those, if it’s ok with you. It’s not a big deal, but it’s always better not to have dialyzer warn against things that actually work.
(Unrelated side note, volley’s doc is great, thank you for that).
Minor typespec correction, allowing to pass the
:all
atom toSpear.read_stream/3
. The functionnality is already supported, this just fixes the spec.