NFT-Worlds / WRLD-Payments-API

https://www.nftworlds.com/
GNU Affero General Public License v3.0
12 stars 14 forks source link

[Suggestion] API Key as a secret #3

Closed tmosleyIII closed 2 years ago

tmosleyIII commented 2 years ago

The API keys can be turned into a secret and then substituted with an additional build step.

on:
  push:
    branches:
      - main
    tags:
      - v*
  pull_request:

jobs:
build:
    runs-on: ubuntu-latest
    steps:
    - name: Checkout
      uses: actions/checkout@v2
    - name: Substitution
      uses: microsoft/variable-substitution@v1 
    with:
        files: 'config.yml'
    env:
        polygon_https_rpc: ${{ secrets.POLYGON_HTTPS_RPC }}
        ethereum_https_rpc: ${{ secrets.ETHEREUM_HTTPS_RPC }}
iamarkdev commented 2 years ago

@Jaxkr tagged you for consideration & your thoughts.

Jaxkr commented 2 years ago

Resolved alongside #10