NG-Studio-Development / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Account Reorder in nightly builds #1553

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to reorder Accounts 
2. Have no response to reorder button
3.

What is the expected output? What do you see instead?
I expect the list to change to a movable list, and be able to change the order 
of accounts.

What version of the product are you using? On what operating system?
nightly-1246, but I've gone back to check and the problem appeared somewhere 
between 1158 which does reorder correctly, and 1174 which is the next lowest 
version I've tested. 

Please provide any additional information below.

Furthermore, it sure seems like it's supposed to try outbound calls on one 
account, then the next, then the next if the first fails to connect . If this 
is the case, then this reorder issue matters. If not, then I supposed it really 
doesn't matter. (either way it sure doesn't seem to be trying accounts 
sequentially when connections fail) 

P.S. This has turned into a seriously awesome product. Great works!!

Original issue reported on code.google.com by r...@guruvan.net on 4 Feb 2012 at 2:02

GoogleCodeExporter commented 9 years ago
Yes, that's a known temporary regression of nightly builds. The move to the new 
android ICS look made me break that the time I rework the reorder list widget 
:).

It will be back soon.

About your last question, that's not the purpose of the ordering stuff.
It is just about display in fact. It's the order accounts appear in the dialer 
widget (and anywhere else there is the button to select the account), and also 
the order you get when csipsimple shows a list with accounts. There is also 
another place where it matters, it's on filtering rules. The app treat accounts 
by priority order when deciding which account to use. So if 2 accounts has a 
rule "force call" that matches the same number, the one that will be chosen is 
the one with higher priority. 

It would be difficult (and not really easy to understand by users) to do some 
auto fallback mechanism. 
The first problem is that in csipsimple dialer you may be allowed to enter full 
sip uris. If not, it use the domain name of the account to add the missing part 
of sip uris. When trying on a different sip service the domain name is more 
likely to be important too : most sip servers use they own domain to route to 
public landline calls.
The second point is that there is not real rule to say that a call failed. If 
you think about the fact the account is not registered, this is already managed 
by the app because it does not allow you to call using an account not 
registered. So it will always be about a feedback of a server that has 
legitimate reason to refuse making call (remote side busy...). 
And final point it will not be very clear for users that select one account 
that the final account used is another one. Many users use sip provider with 
balance and will not be very pleased if the app use credits on another account 
than the one selected ;)

Original comment by r3gis...@gmail.com on 5 Feb 2012 at 12:24

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 21 Mar 2012 at 10:17