NG-ZORRO / ng-zorro-antd-mobile

A configurable Mobile UI components based on Ant Design Mobile and Angular. 🐜
http://ng.mobile.ant.design
Other
800 stars 241 forks source link

fix(module: grid): fix columnNum and carouselMaxRow not work #704

Closed nuonuoge closed 4 years ago

nuonuoge commented 4 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5db6c0b). Click here to learn what that means. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage          ?   87.15%           
=========================================
  Files             ?      164           
  Lines             ?     6740           
  Branches          ?     1102           
=========================================
  Hits              ?     5874           
  Misses            ?      421           
  Partials          ?      445           
Impacted Files Coverage Δ
components/grid/grid.component.ts 88.50% <80.00%> (ø)
components/list/list.component.ts 83.33% <0.00%> (ø)
components/tab-bar/tab-bar.component.ts 91.11% <0.00%> (ø)
components/input-item/input-item.module.ts 100.00% <0.00%> (ø)
components/tabs/tab-pane.component.ts 100.00% <0.00%> (ø)
components/list/brief/brief.component.ts 100.00% <0.00%> (ø)
...ents/slider/slider-steps/slider-steps.component.ts 92.18% <0.00%> (ø)
components/toast/toast.service.ts 91.42% <0.00%> (ø)
components/icon/icon.component.ts 95.65% <0.00%> (ø)
components/tag/tag.module.ts 100.00% <0.00%> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5db6c0b...dde0d89. Read the comment docs.