NG-ZORRO / ng-zorro-antd-mobile

A configurable Mobile UI components based on Ant Design Mobile and Angular. 🐜
http://ng.mobile.ant.design
Other
800 stars 241 forks source link

feat: add [compositionFilter] to InputItem #732

Closed Eve-Sama closed 4 years ago

Eve-Sama commented 4 years ago

close #732

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #731

What is the new behavior?

当[compositionFilter]为true时, 在移动端输入内容, 如中文等需要预览状态的语言, 在完成输入前是不会触发ngModelChange的, 也就是无法更改值. 当[compositionFilter]为false时, 即便在预览模式下也会修改值.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Eve-Sama commented 4 years ago

本地单测全部通过了的.

codecov[bot] commented 4 years ago

Codecov Report

Merging #732 into master will decrease coverage by 0.01%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   87.16%   87.15%   -0.02%     
==========================================
  Files         164      164              
  Lines        6747     6749       +2     
  Branches     1104     1105       +1     
==========================================
+ Hits         5881     5882       +1     
  Misses        421      421              
- Partials      445      446       +1     
Impacted Files Coverage Δ
components/input-item/input-item.component.ts 93.13% <50.00%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7964432...9f704af. Read the comment docs.