NG-ZORRO / ng-zorro-antd-mobile

A configurable Mobile UI components based on Ant Design Mobile and Angular. 🐜
http://ng.mobile.ant.design
Other
799 stars 241 forks source link

fix(module: core): icon add ssr support #783

Closed emondora closed 3 years ago

emondora commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #781

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

codecov[bot] commented 3 years ago

Codecov Report

Merging #783 (3be82e7) into master (26201a9) will increase coverage by 0.01%. The diff coverage is 80.00%.

:exclamation: Current head 3be82e7 differs from pull request most recent head 5254c0d. Consider uploading reports for the commit 5254c0d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   86.86%   86.87%   +0.01%     
==========================================
  Files         164      164              
  Lines        6682     6681       -1     
  Branches     1117     1116       -1     
==========================================
  Hits         5804     5804              
+ Misses        430      429       -1     
  Partials      448      448              
Impacted Files Coverage Δ
components/core/util/icon.ts 89.47% <80.00%> (+1.23%) :arrow_up:
...s/calendar/datepicker/datepicker.base.component.ts 83.63% <0.00%> (-0.61%) :arrow_down:
components/toast/toast.service.ts 88.57% <0.00%> (+2.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26201a9...5254c0d. Read the comment docs.

yuxl01 commented 3 years ago

你好,请问你有联系方式吗?我能请教你一些问题吗?方便qq或者留个常用邮箱也行?

fisherspy commented 3 years ago

你好,请问你有联系方式吗?我能请教你一些问题吗?方便qq或者留个常用邮箱也行?

已更新官网钉钉群二维码,可以扫码入群。 另外代码没有通过travis,可能要修改下。