NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.87k stars 3.93k forks source link

[DatePicker] week parse error #5751

Open hsuanxyz opened 4 years ago

hsuanxyz commented 4 years ago

Reproduction link

https://stackblitz.com/edit/typescript-e85yzr?file=index.ts

Steps to reproduce

*

What is expected?

image

What is actually happening?

image

Environment Info
ng-zorro-antd 9.3.0
Browser *
wenqi73 commented 4 years ago

https://github.com/angular/angular/issues/38739

zorro-bot[bot] commented 3 years ago

Hello @hsuanxyz. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @hsuanxyz, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! giphy

wenqi73 commented 3 years ago

Angular has support ISO week-numbering year 'rrrr', need to change week format to 'rrrr-ww'

Laffery commented 1 year ago

A new issue #7916 which is similar to this one has been raised recently. It seems that we should use YYYY instead of rrrr, see angular/angular#39495.

I'd like to solve that issue. But I doubt about the meaning of this line: why RRRR-II? \ For my perspective, just use YYYY-ww format string for week mode will be OK.