search

NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.86k stars 3.91k forks source link

TimePicker doesn't set value when clicking 'Ok' button when nzDefaultOpenValue is set #6066

Closed KeelanS closed 2 years ago

KeelanS commented 3 years ago

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-ivy-2acsc6

Steps to reproduce

  1. Open the timepicker
  2. Click the 'Ok' button without selecting another time

What is expected?

Since the defaultOpenValue looks selected in the timepicker, I would expect that value to be filled in on clicking 'Ok'. It is also not possible to select this time since clicking on the already selected date won't do anything.

What is actually happening?

The timepicker closes without setting a value

Environment Info
ng-zorro-antd 10.1.2
Browser Chrome

If this is by design, you should at least make it so you can just click the defaultOpenValue to set the field.

KeelanS commented 2 years ago

This got fixed by https://github.com/NG-ZORRO/ng-zorro-antd/pull/6941 I linked it but it looks like it didn't close automatically