NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.86k stars 3.91k forks source link

Extendable Components #6393

Open mixalistzikas opened 3 years ago

mixalistzikas commented 3 years ago

What problem does this feature solve?

There are some features we want to implement to your components, but because it is too specific to our product, we decide to extend your components. The problem is that there are some private observables/subjects/variables that we can not access from our extended components. Why don't you use protected instead of private?

What does the proposed API look like?

private listOfTemplateItem$ = new BehaviorSubject<NzSelectItemInterface[]>([]);
protected listOfTemplateItem$ = new BehaviorSubject<NzSelectItemInterface[]>([]);
zorro-bot[bot] commented 3 years ago

Hello @mixalistzikas. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @mixalistzikas, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! giphy