nz-cascader nzClear not working or implemented

chriso86 commented 3 years ago

Reproduction link

https://github.com/NG-ZORRO/ng-zorro-antd/blob/ab63d7e25aabab8c2fbb2c63294b6b7c08c30480/components/cascader/cascader.component.ts#L252

Steps to reproduce

Try to consume the EventEmitter for nz-cascader called nzClear.

What is expected?

It should emit to the consumer of the component using the nzClear event emitter somewhere, probably in the clearSelection method: cascader.component.ts line 466

What is actually happening?

It doesn't emit anything.

Environment	Info
ng-zorro-antd	11.4.2
Browser	Chrome (Doesn't matter)

I searched through the cascader service and found a method called prepareEmitValue, but nzClear is never emitted anywhere as far as I'm able to see.

zorro-bot[bot] commented 3 years ago

Hello @chriso86. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @chriso86, 我们完全同意你的提议/反馈，欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板，提供改动所需相应的测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！ giphy

wzhudev commented 3 years ago

PR is welcomed!

chriso86 commented 3 years ago

@wendellhu95 Okay cool, I'll make the change now and create the PR. Do I create the PR to "master" branch? What is your ALM model for a fix like this? Do you have a QAS channel?

NG-ZORRO / ng-zorro-antd