NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.87k stars 3.93k forks source link

Sonar issue for ICON compnent - https://ng.ant.design/components/icon/en - to replace <i> tag by <em>. #7470

Open manasa9595 opened 2 years ago

manasa9595 commented 2 years ago

What problem does this feature solve?

Sonar issue as per https://sonarqube.sgp.dbs.com:8443/coding_rules?open=Web%3ABoldAndItalicTagsCheck&rule_key=Web%3ABoldAndItalicTagsCheck

What does the proposed API look like?

Please replace the article to use tag instead of for the icons which reduces developer effort to fix sonarqube issues post code scan.

zorro-bot[bot] commented 2 years ago

Hello @manasa9595. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @manasa9595, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! giphy

wzhudev commented 2 years ago

Should replace <i nz-icon with <span nz-icon in our own code base and demos. A PR will be appreciated.

yndue736 commented 2 years ago

This is amazing you can click on the link pokemon filler list to get the right information about it. They also changes some procedure.