test(module:anchor): added missing tests

ParsaArvanehPA commented 2 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[✔] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe: missing unit tests for the Anchor Component

What is the current behavior?

What is the new behavior?

	Before	After
Statements	99.3%	100%
Branches	89.79%	100%
Functions	100%	100%
Lines	99.27%	100%

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

zorro-bot[bot] commented 2 months ago

This preview will be available after the AzureCI is passed.

ParsaArvanehPA commented 2 months ago

Hi guys @Laffery I think you meant to close and merge, instead you clicked close in this PR.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.15%. Comparing base (2a972d3) to head (bad806d). Report is 5 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8758 +/- ## ======================================= Coverage 93.15% 93.15% ======================================= Files 538 538 Lines 18457 18457 Branches 2816 2816 ======================================= + Hits 17193 17194 +1 + Misses 1226 1225 -1 Partials 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Laffery commented 1 month ago

Hi guys @Laffery I think you meant to close and merge, instead you clicked close in this PR.

I dont know, I have no operations on this PR.

Please fix the CI issues first:)

ParsaArvanehPA commented 1 month ago

Hi guys @Laffery I think you meant to close and merge, instead you clicked close in this PR.

I dont know, I have no operations on this PR.

Please fix the CI issues first:)

The failed test is for the Image component, so I made this Pr for it. It seems to have fixed the problem... .

Laffery commented 1 month ago

Hi guys @Laffery I think you meant to close and merge, instead you clicked close in this PR.

I dont know, I have no operations on this PR. Please fix the CI issues first:)

The failed test is for the Image component, so I made this Pr for it. It seems to have fixed the problem... .

I had merged the fix PR for image compnent, please rebase this pr and trigger the CI againe

Laffery commented 1 month ago

@ParsaArvanehPA It seems that the updating for tick duration from 300 to 600 in image.spec.ts still not works :) What about increasing it to 1000?

ParsaArvanehPA commented 1 month ago

@ParsaArvanehPA It seems that the updating for tick duration from 300 to 600 in image.spec.ts still not works :) What about increasing it to 1000?

This behavior is kinda random. some of today's PRs are fixed and some aren't. Yeah let's get it up to 1000ms. I will first test it in this branch, if it works I will then create a new PR for it.

HyperLife1119 commented 1 month ago

How about converting PLACEHOLDER to Data URL?

const PLACEHOLDER = `data:image/png;base64,...`

ParsaArvanehPA commented 1 month ago

How about converting PLACEHOLDER to Data URL?
const PLACEHOLDER = `data:image/png;base64,...`

Could work 👍 made the change, waiting for the result

NG-ZORRO / ng-zorro-antd