NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.87k stars 3.94k forks source link

fix(module:input): password icon's class name not applied #8768

Closed ParsaArvanehPA closed 1 month ago

ParsaArvanehPA commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The password icon in ant design's Input component has a ant-input-password-icon class name. Our implementation is kinda different than their approch, this makes it not possible for us to alsways set the ant-input-password-icon class name whenever a user is trying to use the password icon for the input's suffix(because we get it as a template). Given that the old style given to tag i did'nt work, that part is deleted and the ant-input-password-icon is given directly to the demo code, making future uses corrent.

Styles for the ant-input-password-icon class already exist.

What is the new behavior?

Does this PR introduce a breaking change?

Other information

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.15%. Comparing base (6311783) to head (f463a9d). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8768 +/- ## ======================================= Coverage 93.15% 93.15% ======================================= Files 538 538 Lines 18456 18457 +1 Branches 2816 2816 ======================================= + Hits 17192 17194 +2 + Misses 1226 1225 -1 Partials 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.