Open ParsaArvanehPA opened 1 month ago
This preview will be available after the AzureCI is passed.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.15%. Comparing base (
dd42ad9
) to head (18f5045
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In RTL mode, there are some issues with the Carousel component. For some weird resone, when you change the direction of the document side to RTL, the
directionality.change
is not emitted; so in the document site you can not see the bugs, This is a recording of the produced bug in the RTL mode.https://github.com/user-attachments/assets/478940db-e63a-4bb4-8067-3f02e0e16245
What is the new behavior?
The footage for the fixed behavior in the RTL mode:
https://github.com/user-attachments/assets/acdbdc7c-4771-4ce1-a7f0-a67c4ca2ab48
Does this PR introduce a breaking change?
Other information
🔶 NOTES:
onLiClick
is not required any more.[dir]="'ltr'"
and didn't put it in the style files becase Ant also gives it as an inline attribute on the HTML: