NG-ZORRO / ng-zorro-antd

Angular UI Component Library based on Ant Design
https://ng.ant.design
MIT License
8.87k stars 3.94k forks source link

fix(module:carousel): carousel not working correctly in rtl mode #8770

Open ParsaArvanehPA opened 1 month ago

ParsaArvanehPA commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

In RTL mode, there are some issues with the Carousel component. For some weird resone, when you change the direction of the document side to RTL, the directionality.change is not emitted; so in the document site you can not see the bugs, This is a recording of the produced bug in the RTL mode.

https://github.com/user-attachments/assets/478940db-e63a-4bb4-8067-3f02e0e16245

What is the new behavior?

The footage for the fixed behavior in the RTL mode:

https://github.com/user-attachments/assets/acdbdc7c-4771-4ce1-a7f0-a67c4ca2ab48

Does this PR introduce a breaking change?

Other information

🔶 NOTES:

image

zorro-bot[bot] commented 1 month ago

This preview will be available after the AzureCI is passed.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.15%. Comparing base (dd42ad9) to head (18f5045).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8770 +/- ## ======================================= Coverage 93.15% 93.15% ======================================= Files 538 538 Lines 18457 18453 -4 Branches 2816 2815 -1 ======================================= - Hits 17193 17190 -3 + Misses 1226 1225 -1 Partials 38 38 ``` | [Flag](https://app.codecov.io/gh/NG-ZORRO/ng-zorro-antd/pull/8770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NG-ZORRO) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/NG-ZORRO/ng-zorro-antd/pull/8770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NG-ZORRO) | `93.15% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NG-ZORRO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.