search

NGEET / fates-docs

Documentation source code for the FATES model
BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

Update stomatal conductance documentation #23

Closed serbinsh closed 3 years ago

serbinsh commented 4 years ago

Adding information related to the addition of Medlyn et al 2011 (USO) representation

Reflects changes made by @Qianyuxuan in FATES PR: https://github.com/NGEET/fates/pull/608

serbinsh commented 4 years ago

Medlyn info based on tech document provided by @Qianyuxuan

Note.for.Medlyn.stomatal.conductance.model.in.FATES-LQY-0515.pdf

serbinsh commented 4 years ago

@Qianyuxuan @walkeranthonyp there is a statement in the original docs under stomatal conductance that I left in thees changes but I am not sure i follow and wonder if it was a typo?

 e_i is the saturation vapor pressure (Pa) inside the leaf at the vegetation temperature conductance (\mumol m^{-2} s^{-1}) when A = 0

https://fates-docs.readthedocs.io/en/latest/fates_tech_note.html#water-stress-on-gas-exchange

Do you happen to know what that is supposed to mean, namely the vapor pressure in the leaf at the "vegetation temperature conductance"? Strange wording. Maybe an accidental cobble together of sentences?

serbinsh commented 4 years ago

@Qianyuxuan ready for review. I tried to squash commits but failed and then had additional mistakes/typos. I think I got it back in order

Qianyuxuan commented 4 years ago

@Qianyuxuan @walkeranthonyp there is a statement in the original docs under stomatal conductance that I left in thees changes but I am not sure i follow and wonder if it was a typo?

 e_i is the saturation vapor pressure (Pa) inside the leaf at the vegetation temperature conductance (\mumol m^{-2} s^{-1}) when A = 0

https://fates-docs.readthedocs.io/en/latest/fates_tech_note.html#water-stress-on-gas-exchange

Do you happen to know what that is supposed to mean, namely the vapor pressure in the leaf at the "vegetation temperature conductance"? Strange wording. Maybe an accidental cobble together of sentences?

Yeah, I think so.

serbinsh commented 4 years ago

@Qianyuxuan @walkeranthonyp there is a statement in the original docs under stomatal conductance that I left in thees changes but I am not sure i follow and wonder if it was a typo?

 e_i is the saturation vapor pressure (Pa) inside the leaf at the vegetation temperature conductance (\mumol m^{-2} s^{-1}) when A = 0

https://fates-docs.readthedocs.io/en/latest/fates_tech_note.html#water-stress-on-gas-exchange Do you happen to know what that is supposed to mean, namely the vapor pressure in the leaf at the "vegetation temperature conductance"? Strange wording. Maybe an accidental cobble together of sentences?

Yeah, I think so.

Sorry that was the wrong link, here is the sentence in the docs I am unsure about

A is leaf photosynthesis (\mumol CO_2 m^{-2} s^{-1}), c_s is the CO_2 partial pressure at the leaf surface (Pa), e_s is the vapor pressure at the leaf surface (Pa), e_i is the saturation vapor pressure (Pa) inside the leaf at the vegetation temperature conductance (\mumol m^{-2} s^{-1}) when A = 0 .

Particularly "e_i is the saturation vapor pressure (Pa) inside the leaf at the vegetation temperature conductance (\mumol m^{-2} s^{-1}) when A = 0 . "

serbinsh commented 3 years ago

@rgknox @glemieux FYI - made some updates here and waiting for the final sign off from @Qianyuxuan. But she is working on her manuscript and we would like to be able to cite these docs in her paper, including the contents of this PR. As such, how should we think about merging doc changes? For example, I believe her code changes are already in master now so we should probably also bring these changes in to make sure docs match code. Is this something we can ask once she is sure its all good? Do you plan to wait for a few more PRs?

Thanks!

CC @alistairrogers

glemieux commented 3 years ago

@serbinsh thanks for the heads up. I'll talk with @rgknox and @ckoven about pushing a new release to update the DOI after merging these updates.

glemieux commented 3 years ago

@Qianyuxuan do the changes that @serbinsh made look good to you? If so, is it ok if I integrate this pull request now or are there more changes forthcoming I should wait for? Thanks.

Qianyuxuan commented 3 years ago

Sorry I just noticed it. I have reviewed the changes before and they look nice. I think it’s ready for integration. Thanks! Best, Cherry

On Feb 12, 2021, at 3:16 PM, Gregory Lemieux notifications@github.com wrote:

@Qianyuxuan https://github.com/Qianyuxuan do the changes that @serbinsh https://github.com/serbinsh made look good to you? If so, is it ok if I integrate this pull request now or are there more changes forthcoming I should wait for? Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NGEET/fates-docs/pull/23#issuecomment-778459226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCCZ7YBBABKB2FKROCXJSLS6WLBRANCNFSM4NG2U5OA.

serbinsh commented 3 years ago

Awesome, thank you @glemieux!