search

NGEET / fates-docs

Documentation source code for the FATES model
BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

added text on reduced-complexity modes, and update author list #34

Closed ckoven closed 1 year ago

ckoven commented 1 year ago

fixes #8.

ckoven commented 1 year ago

@rosiealice could you take a quick look at this and see if I missed or misstated anything important?

ckoven commented 1 year ago

Also, in terms of integration testing, I compiled (sphinxed?) this on my computer and confirm that everything looks as intended.

glemieux commented 1 year ago

Thanks Charlie, this looks great. For future reference, you can also check out the PR test build by clicking on the "Show alll checks". This exposes the test and allows you to click on "Details" to see the test compilation: image

rgknox commented 1 year ago

Looks like it generates and compiles ok: https://fates-users-guide--34.org.readthedocs.build/projects/tech-doc/en/34/fates_tech_note.html#fates-reduced-complexity-configurations

glemieux commented 1 year ago

We decided in today's fates software meeting to move forward to merge this. We discussed having a meeting to review the tech doc in general. Please feel to review the relevant section @rosiealice and create a new PR if needed.