search

NGEET / fates-docs

Documentation source code for the FATES model
BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

new recruitment module #42

Closed rgknox closed 12 months ago

rgknox commented 1 year ago

The Hanbury-Brown et al. recruitment dynamics needs to be added to and/or referenced in the documentation. cc @adamhb

glemieux commented 1 year ago

The associated pull request for reference: https://github.com/NGEET/fates/pull/1021

adamhb commented 1 year ago

Ok, will do!

On Thu, Aug 24, 2023 at 11:21 AM Gregory Lemieux @.***> wrote:

The associated pull request for reference: NGEET/fates#1021 https://github.com/NGEET/fates/pull/1021

— Reply to this email directly, view it on GitHub https://github.com/NGEET/fates-docs/issues/42#issuecomment-1692201308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBXLIJYWMBEWCFMKOQ4VPDXW6LTXANCNFSM6AAAAAA35NF3QI . You are receiving this because you were mentioned.Message ID: @.***>

-- Adam Hanbury-Brown Postdoctoral Scholar UC Davis Lawrence Berkeley National Lab

adamhb commented 1 year ago

Hi @glemieux and @rgknox, I just checked out the documentation contributions instructions, but just to make sure I'm going about it the right way: I'm planning to fork this repo, clone to my personal laptap, make the modifications to the docs, test with a local installation of sphinx, and then submit a pull request once it looks like its compiling well. Is that right? Thanks!

glemieux commented 1 year ago

That's correct! Although if you have trouble with testing the doc compilation locally, know that once you create the PR (and every time you push a commit to said PR) it should run an automated build check which you can review via the link at the bottom of the PR (see the checks section).

adamhb commented 1 year ago

Great, thanks for confirming!On Aug 25, 2023, at 10:27, Gregory Lemieux @.***> wrote: That's correct! Although if you have trouble with testing the doc compilation locally, know that once you create the PR (and every time you push a commit to said PR) it should run an automated build check which you can review via the link at the bottom of the PR (see the checks section).

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>