NGEET / fates-docs

Documentation source code for the FATES model
BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

Update hydraulic failure mortality #61

Closed JessicaNeedham closed 9 months ago

JessicaNeedham commented 10 months ago

Updates the hydraulic failure mortality section to include changes made in PR #1115.

glemieux commented 10 months ago

@JessicaNeedham for some reason I haven't been able to track down, I can't seem to force t_soisno_sl to build correctly with readthedocs. My local build allows it, so it's likely an issue with the readthedocs build environment.
https://github.com/NGEET/fates-docs/blob/5daef38b178feb76a3c0364e3b97b33489a76f51/docs/source/fates_tech_note.rst?plain=1#L3445

I'm going to create an issue and see if I can figure this out a little later.

JessicaNeedham commented 10 months ago

@JessicaNeedham for some reason I haven't been able to track down, I can't seem to force t_soisno_sl to build correctly with readthedocs. My local build allows it, so it's likely an issue with the readthedocs build environment.

https://github.com/NGEET/fates-docs/blob/5daef38b178feb76a3c0364e3b97b33489a76f51/docs/source/fates_tech_note.rst?plain=1#L3445

I'm going to create an issue and see if I can figure this out a little later.

Thanks @glemieux. I couldn't get it to build correctly on my local machine either. We could also change the name to not have the underscores?

glemieux commented 10 months ago

Thanks @glemieux. I couldn't get it to build correctly on my local machine either. We could also change the name to not have the underscores?

That would work to. If I can't get to #62 by the time NGEET/fates#1115 is integrated, let's do that.