Open adrifoster opened 1 year ago
If we make a call to update the history fields before we split and fuse patches from disturbance, I'm pretty sure we don't actually need these fields (at least not all of them). I think they are just there to remember these rates without them getting messed with during the patch re-distribution process. It would be nice to actually get rid of these, that my long-term 2c.
Oh so you mean all of these diagnostics? (almost all?)
In looking at pulling the fates site type into its own module, I noticed that the units and descriptions for many of the site-level mortality diagnostics vary quite a lot and are sometimes contradictory.
For example, for the code below the
term_carbonflux_canopy
and_ustory
say "per canopy level", but I think they should be just for canopy and understory? Theimort_carbonflux
says it is "per year" but then the units say "/sec", etc.Also, it seems like all of the
_crownarea
mortality diagnostics are never updated, though they are used in the history outputs.Does anyone have insights on this?