Add `timesince` attribute to correct "YEAR" calculation for landuse data tool

glemieux commented 1 year ago

Description:

Fixes an error in how the YEAR variable on the output dataset is calculated.

Collaborators:

Expectation of Answer Changes:

Not answer changing to the fates results.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

[x] The in-code documentation has been updated with descriptive comments
[x] The documentation has been assessed to determine if updates are necessary

Integrator

[x] FATES PASS/FAIL regression tests were run
[x] Evaluation of test results for answer changes was performed and results provided

Documentation

Technical Note update:
User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

glemieux commented 1 year ago

Charlie tested this update on perlmutter and it crashed due to input_dataset.time.units.split() not working since there is not units attribute to time.

glemieux commented 1 year ago

Charlie tested this update on perlmutter and it crashed due to input_dataset.time.units.split() not working since there is not units attribute to time.

This has been addressed via 77899da. It is a workaround for issue https://github.com/pydata/xarray/issues/8047 (discovered via https://github.com/pangeo-data/xESMF/issues/286).

NGEET / fates