Closed JessicaNeedham closed 6 months ago
There are three respiration history variables that are listed twice but with different units, but in each case they use the same index.
FATES_AR ih_aresp_si gC/m^2/s FATES_AUTORESP ih_aresp_si kg m-2 s-1 FATES_AR_CANOPY ih_ar_canopy_si gC/m^2/s FATES_AUTORESP_CANOPY ih_ar_canopy_si kg m-2 s-1 FATES_AR_UNDERSTORY ih_ar_understory_si gC/m^2/s FATES_AUTORESP_USTORY ih_ar_understory_si kg m-2 s-1
e.g. https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L8479
https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L8505
I think the correct units for all of them are kg m-2 s-1. In FatesPlantRespPhotosynthMod they are calculated as kg C / indiv / ts and in the history routine get converted to m-2 s-1.
This comment is confusing but I think incorrect: https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L5064
There are three respiration history variables that are listed twice but with different units, but in each case they use the same index.
FATES_AR ih_aresp_si gC/m^2/s FATES_AUTORESP ih_aresp_si kg m-2 s-1 FATES_AR_CANOPY ih_ar_canopy_si gC/m^2/s FATES_AUTORESP_CANOPY ih_ar_canopy_si kg m-2 s-1 FATES_AR_UNDERSTORY ih_ar_understory_si gC/m^2/s FATES_AUTORESP_USTORY ih_ar_understory_si kg m-2 s-1
e.g. https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L8479
https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L8505
I think the correct units for all of them are kg m-2 s-1. In FatesPlantRespPhotosynthMod they are calculated as kg C / indiv / ts and in the history routine get converted to m-2 s-1.
This comment is confusing but I think incorrect: https://github.com/NGEET/fates/blob/43c490df330000a7078edac92c967e64c3788164/main/FatesHistoryInterfaceMod.F90#L5064