NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Add `n_term_mort_types` to the `fates_maxElementsPerSite` calculation to resolve potential restart indexing issues #1189

Closed glemieux closed 7 months ago

glemieux commented 7 months ago

Description:

The pull request is a quick fix to resolve #1182 (also duplicate #1188). A longer term fix for these issues would be to avoid providing these history terms during satellite phenology mode, when they are not needed as suggested by @ckoven.

Collaborators:

@rgknox

Expectation of Answer Changes:

This is not expected to change answers

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

Integrator

Documentation

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

glemieux commented 7 months ago

Regression testing on derecho is complete. All expectected tests pass b4b. The test previously failing exact restart, ERS_Ld30.f45_f45_mg37.I2000Clm51FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhen, is now passing.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1189-fates