NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Minor updates to inventory input and error reporting #1191

Closed mpaiao closed 6 months ago

mpaiao commented 7 months ago

Very minor updates to the inventory initialisation, that should have no impact on simulations.

Description:

This fixes a couple of minor issues that shouldn't affect any simulations at this point.

  1. Land use index should be an integer (currently not used, but it may be useful in the future).
  2. Updated debugging reporting formats, so they are consistent with the variables being reported.

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

Integrator

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

glemieux commented 6 months ago

Regression testing against fates-sci.1.76.1_api.35.1.0-ctsm5.2.004 shows all expected tests passing b4b. Note that this was tested in tandem with #1186.

results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1191-1186-fates