search

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Seed production history output is incorrect #1213

Open JessicaNeedham opened 5 months ago

JessicaNeedham commented 5 months ago

Seed production (carbon from reproductive mass in trees to seed pool) is calculated in EDPhysiologyMod in units of kg C / ha / day. here: https://github.com/NGEET/fates/blob/b8e4eee5ed46daf5c9e710e9ebbe6d20464adbc8/biogeochem/EDPhysiologyMod.F90#L2105

In FatesHistoryInterfaceMod it gets converted to kg C / m2 / sec here: https://github.com/NGEET/fates/blob/b8e4eee5ed46daf5c9e710e9ebbe6d20464adbc8/main/FatesHistoryInterfaceMod.F90#L4040

The divide by days_per_year is not necessary.

It should equal seed allocation since there is no loss of carbon when reproductive tissues is converted to seeds and sure enough when I multiply by 365 in post-processing they are aligned.

Screenshot 2024-06-12 at 18 07 51

JessicaNeedham commented 5 months ago

Branch with a fix is here: https://github.com/JessicaNeedham/fates/tree/jfn-seed-prod-units

It's very minor so can maybe be rolled in with another PR? But happy to make a PR if that is preferred.

JessicaNeedham commented 4 months ago

This will be fixed in #1217